Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119189: Add yet more tests for mixed Fraction arithmetic #119298

Merged
merged 1 commit into from
May 21, 2024
Merged

gh-119189: Add yet more tests for mixed Fraction arithmetic #119298

merged 1 commit into from
May 21, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 21, 2024 •
edited by bedevere-app bot
Loading

I have a branch which changes some details of mixed Fraction arithmetic. Some of changes were still not covered by previous tests.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 21, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 21, 2024
Closed
mdickinson
mdickinson approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 10b1bd9 into python:main May 21, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the tests-fractions-mixed-arithmetic2 branch May 21, 2024 19:28
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@serhiy-storchaka @miss-islington
pythongh-119189: Add yet more tests for mixed Fraction arithmetic (py…
c0e8fe8 
…thonGH-119298)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
@serhiy-storchaka @miss-islington
pythongh-119189: Add yet more tests for mixed Fraction arithmetic (py…
7ffcf54 
…thonGH-119298)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

GH-119346 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 21, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

GH-119347 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 21, 2024
serhiy-storchaka added a commit that referenced this pull request May 21, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-119189: Add yet more tests for mixed Fraction arithmetic (G…
47b09d2 
…H-119298) (GH-119347)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request May 22, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-119189: Add yet more tests for mixed Fraction arithmetic (G…
ec484b6 
…H-119298) (GH-119346)

(cherry picked from commit 10b1bd9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-119189: Add yet more tests for mixed Fraction arithmetic (py…
de7bcf9 
…thonGH-119298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @mdickinson