-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119189: Add more tests for mixed Fraction arithmetic #119236
gh-119189: Add more tests for mixed Fraction arithmetic #119236
Conversation
serhiy-storchaka
commented
May 20, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Fraction wrongfully gets casted into float when given as argument to __rpow__ #119189
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; two nitpick-level comments.
dc34aa1
to
c1f6081
Compare
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…GH-119236) (cherry picked from commit fe67af1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…GH-119236) (cherry picked from commit fe67af1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-119255 is a backport of this pull request to the 3.13 branch. |
GH-119256 is a backport of this pull request to the 3.12 branch. |
I noticed that the newly added tests are written the wrong way around. When a test fails, it says something like
Note how
versus
|
The normal order for assertEqual() is actual, expected. But some old tests are written with other order. We do not touch them to avoid code churn. It seems that old tests here were written in such order, but assertTy po edEquals then reverted the order . |