-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119205: Fix autocompletion bug in new repl #119229
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
@koxudaxi Can you please rebase onto main and move the tests to the newly created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
@ambv @lysnikolaou |
@koxudaxi let the tests complete, don't rebase unless there are conflicts. |
|
The buildbot failure is an unrelated timeout:
|
(cherry picked from commit 506b1a3) Co-authored-by: Koudai Aono <koxudaxi@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
GH-119407 is a backport of this pull request to the 3.13 branch. |
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
If the interpreter shows a warning, the new repl prompt cursor moves after the warning.