Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119205: Fix autocompletion bug in new repl #119229

Merged
merged 15 commits into from
May 21, 2024
Merged

Conversation

koxudaxi
Copy link
Contributor

@koxudaxi koxudaxi commented May 20, 2024

If the interpreter shows a warning, the new repl prompt cursor moves after the warning.

Copy link

cpython-cla-bot bot commented May 20, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@lysnikolaou
Copy link
Member

@koxudaxi Can you please rebase onto main and move the tests to the newly created test_pyrepl directory?

@ambv ambv requested a review from rhettinger as a code owner May 21, 2024 18:46
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ambv ambv added the skip news label May 21, 2024
@lysnikolaou lysnikolaou added the topic-repl Related to the interactive shell label May 21, 2024
@ambv ambv enabled auto-merge (squash) May 21, 2024 19:12
@koxudaxi
Copy link
Contributor Author

@ambv @lysnikolaou
Thank you for reviewing and rebasing my PR.
I apologize I was moving to Pittsburgh airport from the conference center.

@ambv
Copy link
Contributor

ambv commented May 21, 2024

@koxudaxi let the tests complete, don't rebase unless there are conflicts.

@ambv ambv merged commit 506b1a3 into python:main May 21, 2024
42 checks passed
@koxudaxi koxudaxi deleted the fix-issue-119205 branch May 21, 2024 23:35
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit 506b1a3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/8076) and take a look at the build logs.
  4. Check if the failure is related to this commit (506b1a3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/8076

Summary of the results of the build (if available):

Click to see traceback logs
Note: switching to '506b1a3ff66a41c72d205c8e4cba574e439d8e76'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 506b1a3ff6 gh-119205: Fix autocompletion bug in new repl (#119229)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

make: *** wait: No child processes.  Stop.
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes.  Stop.

Cannot open file '/root/buildarea/3.x.angelico-debian-amd64/build/test-results.xml' for upload

@ambv
Copy link
Contributor

ambv commented May 22, 2024

The buildbot failure is an unrelated timeout:

command timed out: 1800 seconds without output running [b'make', b'buildbottest', b'TESTOPTS=-j2 --junit-xml test-results.xml ${BUILDBOT_TESTOPTS}', b'TESTPYTHONOPTS=', b'TESTTIMEOUT=1200'], attempting to kill

@lysnikolaou lysnikolaou added the needs backport to 3.13 bugs and security fixes label May 22, 2024
@miss-islington-app
Copy link

Thanks @koxudaxi for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
(cherry picked from commit 506b1a3)

Co-authored-by: Koudai Aono <koxudaxi@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2024

GH-119407 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
lysnikolaou pushed a commit that referenced this pull request May 22, 2024
…9407)

(cherry picked from commit 506b1a3)

Co-authored-by: Koudai Aono <koxudaxi@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants