-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context #119222
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks @mjdominus for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…expr_context (pythonGH-119222) Add test coverage for "starred kind" in _PyPegen_set_expr_context (cherry picked from commit 8231a24) Co-authored-by: Mark Jason Dominus (陶敏修) <mjd@pobox.com>
…expr_context (pythonGH-119222) Add test coverage for "starred kind" in _PyPegen_set_expr_context (cherry picked from commit 8231a24) Co-authored-by: Mark Jason Dominus (陶敏修) <mjd@pobox.com>
GH-119263 is a backport of this pull request to the 3.13 branch. |
GH-119264 is a backport of this pull request to the 3.12 branch. |
…expr_context (pythonGH-119222) Add test coverage for "starred kind" in _PyPegen_set_expr_context
gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context
That item is on the gh-94808 checklist, but not checked off. I ran
lcov
to confirm that the branch was not covered, added and ran the test, and rebuilt the coverage report to confirm that the branch had now been covered.This pertains to the production
at line 1057 in
python.gram
.Thanks to @encukou for much guidance through this process.