Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context #119222

Merged
merged 1 commit into from
May 20, 2024

Conversation

mjdominus
Copy link
Contributor

@mjdominus mjdominus commented May 20, 2024

gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context

That item is on the gh-94808 checklist, but not checked off. I ran lcov to confirm that the branch was not covered, added and ran the test, and rebuilt the coverage report to confirm that the branch had now been covered.

This pertains to the production

star_target[expr_ty] (memo):
    | '*' a=(!'*' star_target) {
        _PyAST_Starred(CHECK(expr_ty, _PyPegen_set_expr_context(p, a, Store)), Store,
 EXTRA) }
    | target_with_star_atom

at line 1057 in python.gram.

Thanks to @encukou for much guidance through this process.

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label May 20, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@mjdominus mjdominus changed the title Add test coverage for "starred kind" in _PyPegen_set_expr_context gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context May 20, 2024
@mjdominus mjdominus changed the title gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context # gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context May 20, 2024
@mjdominus mjdominus changed the title # gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context #gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context May 20, 2024
@encukou encukou changed the title #gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context May 20, 2024
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou encukou enabled auto-merge (squash) May 20, 2024 20:24
@encukou encukou added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 20, 2024
@encukou encukou merged commit 8231a24 into python:main May 20, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @mjdominus for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
…expr_context (pythonGH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <mjd@pobox.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
…expr_context (pythonGH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <mjd@pobox.com>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

GH-119263 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

GH-119264 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 20, 2024
@mjdominus mjdominus deleted the mjd branch May 22, 2024 03:05
encukou pushed a commit that referenced this pull request Jun 7, 2024
…_expr_context (GH-119222) (GH-119263)

gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context (GH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <mjd@pobox.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…expr_context (pythonGH-119222)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
encukou pushed a commit that referenced this pull request Sep 16, 2024
…_expr_context (GH-119222) (GH-119264)

Add test coverage for "starred kind" in _PyPegen_set_expr_context
(cherry picked from commit 8231a24)

Co-authored-by: Mark Jason Dominus (陶敏修) <mjd@pobox.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants