Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to the docs for itertools.tee() #119135

Merged
merged 4 commits into from
May 18, 2024
Merged

Minor improvements to the docs for itertools.tee() #119135

merged 4 commits into from
May 18, 2024

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented May 18, 2024 •
edited by github-actions bot
Loading

  • Rename variable from empty_link to the more descriptive `shared_link'.
  • Hoist the try/except outside of the inner loop.

📚 Documentation preview 📚: https://cpython-previews--119135.org.readthedocs.build/

@rhettinger rhettinger added docs Documentation in the Doc dir skip issue skip news labels May 18, 2024
@rhettinger rhettinger added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 18, 2024
@rhettinger rhettinger merged commit 81c3130 into python:main May 18, 2024
27 checks passed
@miss-islington-app
Copy link

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@rhettinger rhettinger deleted the itertools_docs branch May 18, 2024 06:32
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
@rhettinger @miss-islington
Minor improvements to the docs for itertools.tee() (pythongh-119135)
d544a97 
(cherry picked from commit 81c3130)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2024
@rhettinger @miss-islington
Minor improvements to the docs for itertools.tee() (pythongh-119135)
525e7ef 
(cherry picked from commit 81c3130)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 18, 2024

GH-119136 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 18, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 18, 2024

GH-119137 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 18, 2024
rhettinger pushed a commit that referenced this pull request May 18, 2024
@miss-islington
[3.13] Minor improvements to the docs for itertools.tee() (gh-119135) (…
374655f 
…gh-119136)
rhettinger pushed a commit that referenced this pull request May 18, 2024
@miss-islington
[3.12] Minor improvements to the docs for itertools.tee() (gh-119135) (…
a370eeb 
…gh-119137)
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@rhettinger @estyxx
Minor improvements to the docs for itertools.tee() (pythongh-119135)
8f1ee90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rhettinger