Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118895: Call PyType_Ready() on typing.NoDefault #118897

Merged
merged 3 commits into from
May 10, 2024
Merged

gh-118895: Call PyType_Ready() on typing.NoDefault #118897

merged 3 commits into from
May 10, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 10, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 10, 2024
Closed
@AlexWaygood AlexWaygood added the needs backport to 3.13 bugs and security fixes label May 10, 2024
sobolevn
sobolevn approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also solves multiple other issues, like:

>>> from typing import NoDefault
>>> NoDefault.__class__
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    NoDefault.__class__
AttributeError: 'NoDefaultType' object has no attribute '__class__'. Did you mean: '__hash__'?

Thanks!

@JelleZijlstra JelleZijlstra mentioned this pull request May 10, 2024
Merged
@sobolevn sobolevn mentioned this pull request May 10, 2024
Merged
@JelleZijlstra JelleZijlstra merged commit 13d7cf9 into python:main May 10, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the readydefault branch May 10, 2024 15:42
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
@JelleZijlstra @miss-islington
pythongh-118895: Call PyType_Ready() on typing.NoDefault (pythonGH-11…
2bdfa85 
…8897)

(cherry picked from commit 13d7cf9)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

GH-118914 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 10, 2024
JelleZijlstra added a commit that referenced this pull request May 10, 2024
@miss-islington @JelleZijlstra
[3.13] gh-118895: Call PyType_Ready() on typing.NoDefault (GH-118897) (…
6df4913 
…#118914)

(cherry picked from commit 13d7cf9)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@JelleZijlstra @estyxx
pythongh-118895: Call PyType_Ready() on typing.NoDefault (python#118897)
1d362c3
@ZeroIntensity ZeroIntensity mentioned this pull request Aug 29, 2024
Closed
@JelleZijlstra JelleZijlstra restored the readydefault branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JelleZijlstra @sobolevn @AlexWaygood