-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119185: Fix typo in _pyrepl.pager
: tempfilepager
should be tempfile_pager
#118881
Conversation
The name with no underscore doesn't exist.
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
_pyrepl.pager
: tempfilepager
should be tempfile_pager
_pyrepl.pager
: tempfilepager
should be tempfile_pager
Thanks @Sachaa-Thanasius for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…be `tempfile_pager` (pythonGH-118881) Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager` The name with no underscore doesn't exist. (cherry picked from commit 05e1dce) Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
GH-119211 is a backport of this pull request to the 3.13 branch. |
…be `tempfile_pager` (python#118881) Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager` The name with no underscore doesn't exist.
The function name has an underscore. Without this, calling help can cause an exception.
Should be reproducible by calling
help()
in the repl on Windows. I personally found it by calling it onsysconfig.get_config_var
.Doesn’t seem worthy of a news entry.