gh-117657: Replace TSAN suppresions with more specific rules #118722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the free-threading TSAN tests are failing. |
|
Tests are passing now but @mpage pointed out that I should probably do some more stress-testing of this before landing, since there are likely more warnings that just show up less frequently. |
colesbury
reviewed
May 7, 2024
|
I'm seeing a race sometimes reported in https://gist.github.com/colesbury/c0a6edcdf7e909191490cedd3873a062 EDIT: there are a few variations of this, and I think something like |
|
Another race between |
colesbury
approved these changes
May 9, 2024
|
Thanks @swtaarrs for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2024
…ythonGH-118722) Using `race:` filters out warnings if the function appears anywhere in the stack trace. This can hide a lot of unrelated warnings, especially for a function like `_PyEval_EvalFrameDefault`, which is somewhere on the stack more often than not. Change all free-threaded suppressions to `race_top:`, which only matches the top frame, and add any new suppressions this exposes. (cherry picked from commit 98ff3f6) Co-authored-by: Brett Simmers <swtaarrs@users.noreply.github.com>
|
GH-118870 is a backport of this pull request to the 3.13 branch. |
colesbury
pushed a commit
that referenced
this pull request
May 9, 2024
…H-118722) (#118870) Using `race:` filters out warnings if the function appears anywhere in the stack trace. This can hide a lot of unrelated warnings, especially for a function like `_PyEval_EvalFrameDefault`, which is somewhere on the stack more often than not. Change all free-threaded suppressions to `race_top:`, which only matches the top frame, and add any new suppressions this exposes. (cherry picked from commit 98ff3f6) Co-authored-by: Brett Simmers <swtaarrs@users.noreply.github.com>
|
|
The buildbot failure looks unrelated |
|
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 10, 2024
…ython#118722) Using `race:` filters out warnings if the function appears anywhere in the stack trace. This can hide a lot of unrelated warnings, especially for a function like `_PyEval_EvalFrameDefault`, which is somewhere on the stack more often than not. Change all free-threaded suppressions to `race_top:`, which only matches the top frame, and add any new suppressions this exposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
race:filters out warnings if the function appears anywhere in the stack trace. This can hide a lot of unrelated warnings, especially for a function like_PyEval_EvalFrameDefault, which is somewhere on the stack more often than not.Change all free-threaded suppressions to
race_top:, which only matches the top frame, and add any new suppressions this exposes. I iterated the test suite under TSAN until it could go 5 times in a row without any new warnings.