-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117928: Bump the minimum Sphinx version to 6.2.1 #117853
Conversation
|
Thanks for pointing this out. |
Now that the 3.11 branch is only accepting security fixes, for 3.12+ I think we can bump the oldest supported Sphinx to at least 6.2.1. Let's open a new issue to do a similar survey to #109209. |
Survey: #117928 |
OK, according to #117928 we can upgrade to Sphinx 6.2.1 as the minimum for the Would you like to update this PR? We can also use that issue number for this PR. There's some compatibility code for old Sphinx we can remove from some files |
I'll update this PR as soon as possible ;) |
Doc/requirements-oldest-sphinx.txt
Thanks, let's also try using 3.12 in python-version: '3.11' # known to work with Sphinx 4.2 |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry, @Eclips4 and @hugovk, I could not cleanly backport this to
|
@Eclips4 Please could you backport? |
Will do it today! |
GH-118321 is a backport of this pull request to the 3.12 branch. |
Fixes https://github.com/python/cpython/security/dependabot/6
FYI, I've followed Victor's instructions from this comment.
📚 Documentation preview 📚: https://cpython-previews--117853.org.readthedocs.build/