Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116720: Fix corner cases of taskgroups #117407

Merged
merged 21 commits into from
Apr 9, 2024
Merged

gh-116720: Fix corner cases of taskgroups #117407

merged 21 commits into from
Apr 9, 2024

Commits on Apr 4, 2024

  1. Fix taskgroups handling of parent cancellation

    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    90695c5 View commit details
    Browse the repository at this point in the history

  2. When errors and parent cancellation are both pending, re-cancel parent

    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6c4876d View commit details
    Browse the repository at this point in the history

  3. When uncancel() reaches zero, clear _must_cancel 

    This fixes the one failing test in test_timeouts.
Surprisingly, it doesn't break any other asyncio tests.
    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    df6e8b7 View commit details
    Browse the repository at this point in the history

  4. Remove 'experimental' comment

    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c762e36 View commit details
    Browse the repository at this point in the history

  5. Remove unneeded Py_CLEAR(self->task_cancel_msg)

    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    4989042 View commit details
    Browse the repository at this point in the history

  6. Simple test for preserving cancelling() level 

    Co-Authored-By: @Tinche
    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    3f91f2d View commit details
    Browse the repository at this point in the history

  7. Add test for nested task groups 

    Co-Authored-By: @arthur-tacca
    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    55ff73f View commit details
    Browse the repository at this point in the history

  8. Add test that is fixed by the re-cancel in __aexit__ 

    Co-Authored-By: @arthur-tacca
    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    50fd8d6 View commit details
    Browse the repository at this point in the history

  9. Test that uncancel() sets _must_cancel to False

    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    93ba76a View commit details
    Browse the repository at this point in the history

  10. Move a stray asyncio news item into the asyncio section

    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f1f89c0 View commit details
    Browse the repository at this point in the history

  11. Add blurb

    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    48c6dda View commit details
    Browse the repository at this point in the history

  12. Add what's new entry

    @gvanrossum
    gvanrossum committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1e20728 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Update uncancel docs

    @gvanrossum
    gvanrossum committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    bc1522c View commit details
    Browse the repository at this point in the history

  2. Update task group docs

    @gvanrossum
    gvanrossum committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    7f6e5ff View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into fix-tg

    @gvanrossum
    gvanrossum committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    56251ff View commit details
    Browse the repository at this point in the history

  4. Fix markup error

    @gvanrossum
    gvanrossum committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c54fb22 View commit details
    Browse the repository at this point in the history

  5. Add attribution to Arthur Tacca issue

    @gvanrossum
    gvanrossum committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    6d4b3d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Wording changes suggested by Carol Willing

    @gvanrossum
    gvanrossum committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b086609 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Changelog/whatsnew updates from Arthur Tacca 

    Also switch to consistently using internal/external
instead of inside/outside.
    @gvanrossum
    gvanrossum committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8ac42f6 View commit details
    Browse the repository at this point in the history

  2. Attempted doc improvements inspired by Arthur Tacca's feedback

    @gvanrossum
    gvanrossum committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ac87a8e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into fix-tg

    @gvanrossum
    gvanrossum committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    be9365c View commit details
    Browse the repository at this point in the history