-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: module page titles should not start with a link to themselves #117099
docs: module page titles should not start with a link to themselves #117099
Conversation
This is only marked Draft because I didn't want to ping 29 other people for review. Can that be stopped? |
I don't know of a way of avoiding that, unfortunately... It's not possible for me to deselect any of the codeowners from the list of people who are going to be requested for review. |
c711468
to
1485c51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I agree that these are distracting for readers, and serve no purpose.
While I agree with @CAM-Gerlach's comments on Discord that a Sphinx extension might be a cleaner way of fixing this, I'm personally happy to merge this unless somebody wants to volunteer to actually do that. I think we should prioritise the experience for readers of the docs, and this PR improves the experience of reading the docs.
Since I don't want to ping 29 code owners, and am a little bit interested in learning about Sphinx internals, let's wait on this to see how the CAM+Ned tag team manages on tweaking Sphinx. |
Everyone: I know this might ping many people. My apologies. The changes were auto-created across all of the module pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
How we did not notice this earlier?
Thanks @nedbat for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…ythonGH-117099) (cherry picked from commit bcb435e) Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
…ythonGH-117099) (cherry picked from commit bcb435e) Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
GH-118790 is a backport of this pull request to the 3.13 branch. |
GH-118791 is a backport of this pull request to the 3.12 branch. |
The
:mod:
role used in the title of module pages turns into a link, but the link is to the same page. That's distracting and unhelpful. This uses the!
prefix to instruct Sphinx to not make a link.This was done with this thrown-together program:
📚 Documentation preview 📚: https://cpython-previews--117099.org.readthedocs.build/