GH-116422: Factor out eval breaker checks at end of calls into its own micro-op. #116817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
approved these changes
Mar 14, 2024
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
…its own micro-op. (pythonGH-116817)
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…its own micro-op. (pythonGH-116817)
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…its own micro-op. (pythonGH-116817)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main PR for hot/cold splitting (#116813) can only support a limited number of exits per micro-op.
Most call micro-ops can deopt, error and check the eval breaker which is too much for tier 2 to support.
This PR:
_CHECK_PERIODICuop to check the eval breaker_CALL... ; _CHECK_PERIODICso that the component uops can be handled in tier 2.