gh-70647: Better promote how to safely parse yearless dates in datetime. #116179
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…datetime. Every four years people encounter this because it just isn't obvious. This moves the footnote up to a note with a code example. We'd love to change the default year value for datetime but doing that could have other consequences for existing code. This documented workaround *always* works.
itamaro
approved these changes
Mar 1, 2024
| >>> datetime.strptime(value, "%m/%d") | ||
| Traceback (most recent call last): | ||
| ... | ||
| ValueError: day is out of range for month |
There was a problem hiding this comment.
this will need updating after your other PR is merged :) (so beware of the potential merge race between the two)
1 task
|
Perhaps this should be only merged to the backport branches, not main. |
pganssle
approved these changes
Apr 2, 2024
|
@gpshead Looks like this may need some tidying up if you are still interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every four years people encounter this in part because it just isn't obvious that partial incomplete date parsing is not what
datetime.strptimeis designed for. This moves the footnote up to a more explanatory inline note with a code example.We'd love the default year value for datetime to be different, but changing that could have other consequences for existing code. This documented workaround always works.
📚 Documentation preview 📚: https://cpython-previews--116179.org.readthedocs.build/