Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LOGGING example taken from Django docs. #114903

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Feb 2, 2024

For example, Django no longer provides a custom NullHandler: django/django@6c66a41.

I intentionally left single quotes to minimize the diff.

https://docs.djangoproject.com/en/5.0/topics/logging/#configuring-logging


📚 Documentation preview 📚: https://cpython-previews--114903.org.readthedocs.build/

@felixxm felixxm requested a review from vsajip as a code owner February 2, 2024 10:55
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 2, 2024
For example, Django no longer provides a custom NullHandler

django/django@6c66a41
@felixxm felixxm force-pushed the logging-django-example branch from 61fc801 to e1ef619 Compare February 2, 2024 10:57
Doc/howto/logging-cookbook.rst Outdated Show resolved Hide resolved
Doc/howto/logging-cookbook.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Feb 2, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hugovk hugovk added skip issue needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Feb 3, 2024
@hugovk hugovk merged commit 28bb296 into python:main Feb 3, 2024
27 of 28 checks passed
@miss-islington-app
Copy link

Thanks @felixxm for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2024
For example, Django no longer provides a custom NullHandler

django/django@6c66a41

* Remove require_debug_true.
(cherry picked from commit 28bb296)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 3, 2024

GH-114951 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 3, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2024
For example, Django no longer provides a custom NullHandler

django/django@6c66a41

* Remove require_debug_true.
(cherry picked from commit 28bb296)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 3, 2024

GH-114952 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 3, 2024
hugovk pushed a commit that referenced this pull request Feb 3, 2024
…14952)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
hugovk pushed a commit that referenced this pull request Feb 3, 2024
…14951)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
For example, Django no longer provides a custom NullHandler

django/django@6c66a41

* Remove require_debug_true.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
For example, Django no longer provides a custom NullHandler

django/django@6c66a41

* Remove require_debug_true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants