Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-114788: Do not run JIT workflow on unrelated changes #114789

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 31, 2024

First change is about concurrency:. We simply cancel previous runs not to waste resources.

Second, docs say that paths should be like this:
Снимок экрана 2024-01-31 в 11 44 41

Plus, I also included **/*jit*.* to match any files with jit prefix or suffix in its name.

First run: changed jit.yml
Снимок экрана 2024-01-31 в 11 50 33

JIT workflow is there ✅

Second run: added a PR to this branch in my fork with unrelated changes.

Снимок экрана 2024-01-31 в 11 58 56

No JIT workflow ✅

@hugovk
Copy link
Member

hugovk commented Jan 31, 2024

Second, docs say that paths should be like this: Снимок экрана 2024-01-31 в 11 44 41

Plus, I also included **/*jit*.* to match any files with jit prefix or suffix in its name.

Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

They also say:

  • *: Matches zero or more characters, but does not match the / character. For example, Octo* matches Octocat.
  • **: Matches zero or more of any character.

I wonder why paths: '**jit**' didn't work?

Does it work like this?

    paths:
      - '**jit**'

@hugovk
Copy link
Member

hugovk commented Jan 31, 2024

Does it work like this?

    paths:
      - '**jit**'

I think it might, PyCharm warns that an array is needed:

image

.github/workflows/jit.yml Outdated Show resolved Hide resolved
.github/workflows/jit.yml Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@sobolevn
Copy link
Member Author

Let's try it! Since this way is much easier.

@sobolevn
Copy link
Member Author

After new changes:

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a minute, changing bytecode also means the JIT stencils generated will change. So I think we should also detect for changes in Python/bytecodes.c.

@bedevere-app
Copy link

bedevere-app bot commented Jan 31, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brandtbucher
Copy link
Member

Just so I understand, the concurrency thing is just to cancel runs that may still be in-progress for earlier commits on the same branch?

@sobolevn
Copy link
Member Author

Yes :)

@hugovk hugovk merged commit b25b746 into python:main Jan 31, 2024
43 of 45 checks passed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…#114789)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants