-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112532: Fix peg generator build.py for mimalloc build #113492
Conversation
AS-IS
TO-BE
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we can do this unconditionally on the mimalloc build no?
Or we can use |
Nah is fine, just wanted to ensure that the header include is correct independently if we have mimalloc or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
Yeah, I think the include path is fine even if we are not compiling with mimalloc support.
We always include Lines 1795 to 1800 in acf3bcc
|
…ngh-113492) pythongh-112532: Fix peg generator for mimalloc build
…ngh-113492) pythongh-112532: Fix peg generator for mimalloc build
…ngh-113492) pythongh-112532: Fix peg generator for mimalloc build
--disable-gil
builds #112532