GH-111485: Mark some instructions as TIER_ONE_ONLY
#113155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
added
skip news
interpreter-core
brandtbucher
requested review from
markshannon and
gvanrossum
as code owners
|
Maybe eventually the tier-one-only marker could be one of the instruction attributes (like |
|
Yeah, I would like that too. The less we need to poke around in the token soup (and keep things in the DSL header) the better. |
|
Go for it!
…On Fri, Dec 15, 2023 at 11:47 AM Brandt Bucher ***@***.***> wrote:
Yeah, I would like that too.
The less we need to poke around in the token soup (and keep things in the
DSL header) the better.
—
Reply to this email directly, view it on GitHub
<#113155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWCWMXFPDXFMBTNGONY7T3YJSSLTAVCNFSM6AAAAABAWA4SYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGQYDMOJUGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
--Guido van Rossum (python.org/~guido)
|
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent refactoring has made it so that the interpreter generator is now emitting executor cases for some instructions that were implicitly non-viable as uops before. This marks those instructions as explicitly
TIER_ONE_ONLY.