-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-110793: add GitHub Actions job that runs tests after installing #110794
base: main
Are you sure you want to change the base?
Conversation
FFY00
commented
Oct 13, 2023
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: Add GitHub Actions job that runs the tests in an installed Python #110793
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
The job is now successful, this is ready for review. I'd still wait a little bit before merging, to see if there is any discussion on the issue. |
Signed-off-by: Filipe Laíns <lains@riseup.net>
--with-openssl-rpath | ||
- name: Build CPython out-of-tree | ||
working-directory: ${{ env.CPYTHON_BUILDDIR }} | ||
run: make -j4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's the number of threads for Linux and Windows.
In this PR, I just copied the other jobs, so this comes from there. We can do the improvements you are suggesting (would also be nicer when running locally with act for eg), but it should probably be in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go for this, let's do them as reusable workflows: Examples:
Possibly also |
I noticed
Let's try adding them to the new job.
Agreed. Do you want to implement that in this PR or in a followup one? |
It would be good in this PR. |