Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] GH-106176, GH-104702: Fix reference leak when importing across multiple threads (GH-108497) #108612

Merged
merged 1 commit into from
Aug 29, 2023
Merged

[3.12] GH-106176, GH-104702: Fix reference leak when importing across multiple threads (GH-108497) #108612

merged 1 commit into from
Aug 29, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 29, 2023 •
edited by bedevere-bot
Loading

(cherry picked from commit 5f85b44)

Co-authored-by: Brett Cannon brett@python.org

@brettcannon @miss-islington
pythonGH-106176, pythonGH-104702: Fix reference leak when importing a…
d2f0afd 
…cross multiple threads (pythonGH-108497)

(cherry picked from commit 5f85b44)

Co-authored-by: Brett Cannon <brett@python.org>
This was referenced Aug 29, 2023
Closed
Merged
vstinner
vstinner approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

That's an important refleak fix. Refleaks buildbots are failing for a few weeks because of it.

@Eclips4 Eclips4 mentioned this pull request May 21, 2023
Closed
@Yhg1s Yhg1s merged commit c942fae into python:3.12 Aug 29, 2023
26 checks passed
@miss-islington miss-islington deleted the backport-5f85b44-3.12 branch August 29, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

@Yhg1s Yhg1s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @vstinner @Eclips4 @Yhg1s @bedevere-bot @brettcannon