gh-108113: Make it possible to optimize an AST #108282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Aug 22, 2023
•
iritkatriel
commented
- Issue: compile() with PyCF_ONLY_AST flag ignores the optimize arg #108113
|
Skipping news as the previous PR's news covers this. |
carljm
approved these changes
Aug 22, 2023
Python/bltinmodule.c
Outdated
| @@ -804,25 +804,39 @@ builtin_compile_impl(PyObject *module, PyObject *source, PyObject *filename, | |||
| if (is_ast == -1) | |||
| goto error; | |||
| if (is_ast) { | |||
| PyArena *arena = _PyArena_New(); | |||
There was a problem hiding this comment.
I wonder if anyone has perf-sensitive code that does ast.parse on an AST as a no-op, and what the impact on that code will be of allocating and freeing an unused arena. Probably not an issue? I think it would be possible, but slightly more complex, to still avoid arena allocation in the no-op case.
carljm
approved these changes
Aug 23, 2023
iritkatriel
changed the title
|
There's a new commit after the PR has been approved. @carljm: please review the changes made to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.