Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104050: Argument clinic: complete type annotations #107399

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jul 28, 2023

Enable mypy --strict, ensuring that mypy will from now on complain if new functions without type annotations are added, and, if they are added anyway, will also check functions that don't have type annotations.

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Also, the _module_and_class function became slightly more readable.

@AlexWaygood AlexWaygood merged commit 55ed85e into python:main Jul 28, 2023
18 checks passed
@AlexWaygood AlexWaygood deleted the clinic-complete-typing branch July 28, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants