gh-95855: Refactor platform triplet detection code, add detection for MIPS soft float and musl libc #107221
Conversation
musl supports SPE with its soft-float ABI: https://git.musl-libc.org/cgit/musl/commit/?id=7be59733d71ada3a32a98622507399253f1d5e48
|
Thanks! I liked Christian's initial efforts in #96001; thanks for picking this up. Instead of the grep exercises; what do you think of the |
That would require fully compiling the program (the current approach only requires the preprocessing step) and running it to get the output, which would not be feasible when cross-compiling. My preference would be something similar to config.guess, where we output the triplet with a prefix like |
That's a good point.
Yeah, I would prefer something like that. |
Updated 👍 |
erlend-aasland
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 7fb142c 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Not sure if the buildbot errors are related to this change? |
Yeah, unfortunately we'll have to examine each bot. I'll see if I can find time later. Feel free to take a look yourself :) |
|
I have looked at every error log - while the errors do not look related to this change to me, I'm not familiar enough with the tests being run to say for certain. |
|
Is there anything else I can do to help resolve the buildbot errors (perhaps update/rebase the branch)? |
|
I did a fairly quick inspection of the buildbot run. Feel free to go through them as well (or even better a different subset).
As you see, there are some changes. Also, I noticed this configure warning in the Gentoo Non-Debug buildbot (despite it getting the
|
|
AA-Turner
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit cbaf416 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
@jefferyto I've kicked off another buildbot run for your latest changes. A |
|
@AA-Turner thanks! |
|
Thanks, Adam! @jefferyto, can you do an audit of the buildbot run when it completes? I won't be able to return to this until probably late next week. |
|
Wow, good job! Thank you so much. I'll try to find time to verify it the coming week. |
|
@erlend-aasland ping 🙏 |
|
@corona10, do you want to have a look? |
|
@tiran, if you are around; feel free to have a look :) |
|
Okay I will take a look but please wait until this weekend ;) |
Sure, there is no hurry :) |
|
cc. @indygreg |
|
Thanks @jefferyto, Christian, and Dong-hee! |
|
Thanks @erlend-aasland for your help as well! |
Most of the ideas in this come from #96001 so @tiran deserves the credit. But since the platform triplet detection code in configure.ac has changed since #96001, and because that PR is still in an unfinished state, I thought it would make more sense to reimplement it (as well as split it into commits that explain the major steps).