Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104050: Argument Clinic: Increase CConverter typing coverage #106932

Merged
merged 3 commits into from
Jul 20, 2023
Merged

gh-104050: Argument Clinic: Increase CConverter typing coverage #106932

merged 3 commits into from
Jul 20, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 20, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 20, 2023
Closed
AlexWaygood
AlexWaygood reviewed Jul 20, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood reviewed Jul 20, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, providing the tests all pass with the default values removed!

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 20, 2023 22:37
@erlend-aasland
Copy link
Contributor Author

Thanks for the review!

@erlend-aasland erlend-aasland merged commit 1d5a625 into python:main Jul 20, 2023
17 checks passed
@erlend-aasland erlend-aasland deleted the clinic/annotate-cconverter-more branch July 22, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @AlexWaygood @bedevere-bot