Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104050: Argument Clinic: Annotate Clinic.parse() #106760

Merged
merged 6 commits into from
Jul 17, 2023
Merged

gh-104050: Argument Clinic: Annotate Clinic.parse() #106760

merged 6 commits into from
Jul 17, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 14, 2023 •
edited
Loading

@erlend-aasland
pythongh-104050: Argument Clinic: Annotate Clinic.parse()
dd434fb 
As a consequence, also add a generic Parser ABC
@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Closed
AlexWaygood
AlexWaygood reviewed Jul 15, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks, but nothing blocking!

Tools/clinic/clinic.py Outdated Show resolved Hide resolved
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
erlend-aasland and others added 2 commits July 17, 2023 01:25
@erlend-aasland @AlexWaygood
Apply suggestions from code review
2c9075d 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland @AlexWaygood
Update Tools/clinic/clinic.py
96dae0c 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland erlend-aasland enabled auto-merge (squash) July 16, 2023 23:27
@erlend-aasland erlend-aasland merged commit 383dcbe into python:main Jul 17, 2023
16 checks passed
@erlend-aasland erlend-aasland deleted the clinic/annotate-clinic-parse branch July 17, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @AlexWaygood @bedevere-bot