Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106368: Increase Argument Clinic BlockParser test coverage #106759

Merged
merged 4 commits into from
Jul 15, 2023
Merged

gh-106368: Increase Argument Clinic BlockParser test coverage #106759

merged 4 commits into from
Jul 15, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 14, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jul 14, 2023
Merged
@erlend-aasland erlend-aasland requested a review from sobolevn July 14, 2023 22:30
sobolevn
sobolevn reviewed Jul 15, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erlend-aasland
Pull in main
83f5dc3
@erlend-aasland
Address Nikita's review:
c7caf05 
Let expect_failure() dedent and strip input string
@erlend-aasland
Address Nikita's review:
8173cd1 
Assert stuff in test_parse_with_body_prefix()
@erlend-aasland erlend-aasland requested a review from sobolevn July 15, 2023 08:44
sobolevn
sobolevn approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erlend-aasland erlend-aasland merged commit 2d7d1aa into python:main Jul 15, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the clinic/buffer-stuff-coverage branch July 15, 2023 09:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic BlockParser test coverage (p…
c067013 
…ythonGH-106759)

(cherry picked from commit 2d7d1aa)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106769 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 15, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic BlockParser test coverage (p…
90cd2e2 
…ythonGH-106759)

(cherry picked from commit 2d7d1aa)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106770 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 15, 2023
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Nikita!

erlend-aasland added a commit that referenced this pull request Jul 15, 2023
@miss-islington @erlend-aasland
[3.11] gh-106368: Increase Argument Clinic BlockParser test coverage (G…
b132b77 
…H-106759) (#106770)

(cherry picked from commit 2d7d1aa)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 15, 2023
@miss-islington @erlend-aasland
[3.12] gh-106368: Increase Argument Clinic BlockParser test coverage (G…
1fe8412 
…H-106759) (#106769)

(cherry picked from commit 2d7d1aa)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @miss-islington @bedevere-bot @sobolevn