-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-105090: Replace incorrect TLSv1.2 with TLSv1.3 #105404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have also looked for other potential occurrences in the whole file, but none found.
I have done this review during the EuroPython 2023 sprints.
Thanks @pandaninjas for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12. |
Sorry @pandaninjas and @pablogsal, I had trouble checking out the |
GH-107038 is a backport of this pull request to the 3.11 branch. |
) (cherry picked from commit e5252c6) Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
GH-107039 is a backport of this pull request to the 3.10 branch. |
Thanks @pandaninjas for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
GH-107040 is a backport of this pull request to the 3.12 branch. |
) (cherry picked from commit e5252c6) Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
) (cherry picked from commit e5252c6) Co-authored-by: Jocelyn Castellano <admin@malwarefight.gq>
The ssl doc specifies that it will only allow >=TLSv1.2, while the code actually only allows TLSv1.3
📚 Documentation preview 📚: https://cpython-previews--105404.org.readthedocs.build/