gh-104855: Update more tk tests for 8.7 #105047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where applicable: * Add '' to the valid options in error messages. * Test that '' is valid. * Test that 'to' < 'from' is valid instead of invalid. This PR also fixes pythongh-104856.
terryjreedy
added
tests
|
As before, I will wait for Christopher to test on 8.7 and Serhiy to comment and possibly revise. |
|
@serhiy-storchaka Please review |
serhiy-storchaka
added
needs backport to 3.13
|
@terryjreedy, there were errors in these fixes, and there were also many other test failures (and even crashes, due to Tk bugs). I fixed them all (at least on Linux), and think that this is ready to merge. If there are Windows or macOS specific failures, they can be fixed in a separate PR. |
serhiy-storchaka
force-pushed
the
tk87tests
branch
from
1a6276a
to
dea00ba
Compare
serhiy-storchaka
force-pushed
the
tk87tests
branch
from
59e0b40
to
358bb74
Compare
|
I expected to only fix few errors in this PR by committing in the original branch, but it required much more changes. So I created a branch in my repository and a new PR #120824. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where applicable:
This PR also addresses gh-104856 .