Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104773: PEP 594: Remove the chunk module #104868

Merged
merged 1 commit into from
May 25, 2023
Merged

gh-104773: PEP 594: Remove the chunk module #104868

merged 1 commit into from
May 25, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 24, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
19 tasks
hugovk
hugovk requested changes May 24, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove Doc/library/chunk.rst from Doc/tools/.nitignore

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner
Copy link
Member Author

Let's also remove Doc/library/chunk.rst from Doc/tools/.nitignore

Oh, I missed that one: it's now removed.

@vstinner
Copy link
Member Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from hugovk May 24, 2023 15:16
hugovk
hugovk approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner vstinner enabled auto-merge (squash) May 24, 2023 15:26
@vstinner
Copy link
Member Author

Oh. test_aifc uses the chunk module. It should be removed before the chunk module can be removed:

test test_aifc crashed -- Traceback (most recent call last):
(...)
  File "D:\a\cpython\cpython\Lib\aifc.py", line 260, in <module>
    from chunk import Chunk
ModuleNotFoundError: No module named 'chunk'

@vstinner vstinner marked this pull request as draft May 24, 2023 15:43
auto-merge was automatically disabled May 24, 2023 15:43

Pull request was converted to draft

@vstinner vstinner changed the title gh-104773: PEP 594: Remove the chunk module WIP (aifc must be removed first): gh-104773: PEP 594: Remove the chunk module May 24, 2023
@vstinner vstinner mentioned this pull request May 25, 2023
Merged
@vstinner vstinner changed the title WIP (aifc must be removed first): gh-104773: PEP 594: Remove the chunk module gh-104773: PEP 594: Remove the chunk module May 25, 2023
@vstinner vstinner marked this pull request as ready for review May 25, 2023 16:02
@vstinner
Copy link
Member Author

PR rebased on main, now that the aifc module has been removed.

@vstinner vstinner enabled auto-merge (squash) May 25, 2023 16:09
@vstinner vstinner merged commit 77d7ec5 into python:main May 25, 2023
@vstinner vstinner deleted the remove_chunk branch May 25, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @bedevere-bot @hugovk