Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104050: Add basic type hints to Argument Clinic DSL parser #104704

Merged
merged 2 commits into from
May 20, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 20, 2023

@erlend-aasland
Copy link
Contributor Author

The rest of the parser needs special treatment; this is only the low-hanging fruit.

Tools/clinic/clinic.py Outdated Show resolved Hide resolved
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than my suggestion in #104704 (comment)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland erlend-aasland enabled auto-merge (squash) May 20, 2023 21:31
@erlend-aasland erlend-aasland merged commit 27a68be into python:main May 20, 2023
@erlend-aasland erlend-aasland deleted the typed-clinic/parser branch May 21, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants