Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104539: Fix indentation error in logging.config.rst #104540

Closed
wants to merge 1 commit into from

Conversation

jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented May 16, 2023

I think this should solve #104539, but I'm not entirely sure.


📚 Documentation preview 📚: https://cpython-previews--104540.org.readthedocs.build/

@jnoordsij jnoordsij requested a review from vsajip as a code owner May 16, 2023 10:58
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 16, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovk
Copy link
Member

hugovk commented May 16, 2023

Please could you make this PR against the main branch instead of 3.11? We can then backport it to 3.11 from there.

Don't change the base branch at the top of this PR, because it rarely works as planned and ends up pinging lots of people through the CODEOWNERS file. Instead, close this PR and re-open a new one.

Thank you!

@hugovk hugovk removed the request for review from vsajip May 16, 2023 11:10
@vsajip
Copy link
Member

vsajip commented May 16, 2023

I'll close this, and wait for the patch against the main branch.

@vsajip vsajip closed this May 16, 2023
@jnoordsij
Copy link
Contributor Author

Please could you make this PR against the main branch instead of 3.11? We can then backport it to 3.11 from there.

Don't change the base branch at the top of this PR, because it rarely works as planned and ends up pinging lots of people through the CODEOWNERS file. Instead, close this PR and re-open a new one.

Thank you!

Ah that makes sense! Will open a new PR soon.

@jnoordsij jnoordsij deleted the patch-1 branch May 16, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants