Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104328: Fix typo in typing.Generic multiple inheritance error message #104335

Merged
merged 1 commit into from
May 9, 2023
Merged

gh-104328: Fix typo in typing.Generic multiple inheritance error message #104335

merged 1 commit into from
May 9, 2023

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented May 9, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 9, 2023
Closed
@Eclips4 Eclips4 changed the title gh-104328: Fix typo in error gh-104328: Fix typo in error message May 9, 2023
@gvanrossum gvanrossum removed their request for review May 9, 2023 17:34
AA-Turner
AA-Turner approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct per issue.

A

@AA-Turner AA-Turner changed the title gh-104328: Fix typo in error message gh-104328: Fix typo in typing.Generic multiple inheritance error message May 9, 2023
@carljm carljm merged commit 01c321c into python:main May 9, 2023
@carljm carljm added the needs backport to 3.11 only security fixes label May 9, 2023
@miss-islington
Copy link
Contributor

Thanks @Eclips4 for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-104338 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 9, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2023
@Eclips4 @miss-islington
pythongh-104328: Fix typo in typing.Generic multiple inheritance …
528cc01 
…error message (pythonGH-104335)

(cherry picked from commit 01c321c)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
AlexWaygood pushed a commit that referenced this pull request May 9, 2023
@miss-islington @Eclips4
[3.11] gh-104328: Fix typo in typing.Generic multiple inheritance…
663b321 
… error message (GH-104335) (#104338)

gh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (GH-104335)
(cherry picked from commit 01c321c)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@Eclips4 Eclips4 deleted the issue_104328 branch May 9, 2023 20:00
carljm added a commit to carljm/cpython that referenced this pull request May 10, 2023
@carljm
Merge branch 'main' into fixloadsuperspec
5976df9 
* main:
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226)
  pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849)
  pythongh-74895: adjust tests to work on Solaris (python#104326)
  pythongh-101819: Refactor _io in preparation for module isolation (python#104334)
  pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322)
  pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request()
  pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Eclips4 @miss-islington @bedevere-bot @AA-Turner @carljm