-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-77609: Support following symlinks in pathlib.Path.glob()
#104176
GH-77609: Support following symlinks in pathlib.Path.glob()
#104176
Conversation
How does this help us fix the mixed up behaviour of the current function? |
I don't think the current behaviour is wrong, just difficult to optimize. With this PR, users would be able to recursively walk symlinks, and we'd be able to optimize |
I'm surprised, because you closed the other PR saying you were convinced this was the way forward. Personally, I preferred the other way. It's a bit more work, but in ~5 years time we'll have forgotten about it and will just have sensible defaults. Adding this way and leaving the other one leaves us with two warts (okay, maybe 1.5, if people like this, but I feel like special patterns specifically for symlinks is too much). |
I know. I literally changed my mind again last night while playing around with the
👍 fair point, thanks for the advice. |
Closing in favour of #102616 |
Add support for
***
wildcard inpathlib.Path.glob()
andrglob()
. This wildcard works like**
, except that it also recurses into symlinks.See Recursive Globbing in the zshexpn manpage for prior art.
Alternative to #102616