gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on non-X11 #103821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that, as an alternative to testing with unusual hardware, utilities like Karabiner Elements, AutoHotKey, and |
This comment was marked as outdated.
This comment was marked as outdated.
…which was broken due to incorrect delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.
serhiy-storchaka
changed the title
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2024
…on-X11 (pythonGH-103821) Also fix test_mousewheel: do not skip a check which was broken due to incorrect delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`. (cherry picked from commit d25d4ee) Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
|
GH-114901 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2024
…on-X11 (pythonGH-103821) Also fix test_mousewheel: do not skip a check which was broken due to incorrect delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`. (cherry picked from commit d25d4ee) Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
|
GH-114902 is a backport of this pull request to the 3.11 branch. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…on-X11 (pythonGH-103821) Also fix test_mousewheel: do not skip a check which was broken due to incorrect delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…on-X11 (pythonGH-103821) Also fix test_mousewheel: do not skip a check which was broken due to incorrect delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested as a patch for 3.11.3 with Tk 8.6.13 (for both Aqua and XQuartz).