GH-80486: Fix handling of NTFS alternate data streams in pathlib #102454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barneygale
changed the title
|
This won't backport as it relies on a number of internal changes in 3.12 only. |
zooba
reviewed
Mar 6, 2023
zooba
approved these changes
Mar 6, 2023
eryksun
reviewed
Mar 6, 2023
|
Are we going to wait for #102511 to be implemented? Or leave a note in that one to update this use when it's done? As this issue is about correctness and the other is about performance, I'd prefer not to wait. |
|
Personally I'd rather not wait! :) |
|
Feel free to merge (and backport as appropriate), then! |
|
I'm not a core dev so I don't have any merge permissions I don't think! 😅 |
|
Oh aren't you? We should probably fix that 😉 (though I'm literally about to step away for the weekend, so next week) |
|
(and unfortunately this won't backport due to other changes in 3.12 being required) |
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Mar 12, 2023
pythonGH-102454) Co-authored-by: Maor Kleinberger <kmaork@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes round-tripping of Windows paths like
./c:ain pathlib.Previously, pathlib removed the
./prefix when generating a string representation of such paths. This changed the meaning, from a file in the current directory called "c" with an NTFS alternate data stream, to a relative path on the "c:" drive.Most of the patch by @kmaork. I brought it up-to-date.