Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101709

Merged
merged 2 commits into from
Feb 9, 2023
Merged

[3.9] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) #101709

merged 2 commits into from
Feb 9, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 8, 2023 •
edited by bedevere-bot
Loading

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin oleg@arhadthedev.net

@arhadthedev @miss-islington
pythongh-101283: Improved fallback logic for subprocess with shell=Tr…
fccaea3 
…ue on Windows (pythonGH-101286)

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
This was referenced Feb 8, 2023
Closed
Merged
@bedevere-bot bedevere-bot added the type-security A security issue label Feb 8, 2023
zooba
zooba reviewed Feb 8, 2023
View reviewed changes
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Doc/library/subprocess.rst Outdated Show resolved Hide resolved
Lib/subprocess.py Outdated Show resolved Hide resolved
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@arhadthedev arhadthedev marked this pull request as draft February 9, 2023 03:39
@arhadthedev
Copy link
Member

Undrafting since the introduced bug will be fixed separately by backports of gh-101712. My apologizes for the confusion; I didn't sort out my incoming notifications timely.

@arhadthedev arhadthedev marked this pull request as ready for review February 9, 2023 06:14
@ambv ambv merged commit 04cc427 into python:3.9 Feb 9, 2023
@miss-islington miss-islington deleted the backport-23751ed-3.9 branch February 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees
No one assigned
Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @arhadthedev @zooba @ambv @bedevere-bot