gh-98831: rewrite MAKE_FUNCTION and BUILD_SLICE in the instruction definition DSL #101529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Feb 3, 2023
•
iritkatriel
commented
- Issue: Generate the interpreter #98831
iritkatriel
added
skip news
interpreter-core
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 90ff55e 🤖 If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
🔨 test-with-buildbots
gvanrossum
approved these changes
Feb 3, 2023
| kwdefaults if (oparg & 0x02), | ||
| annotations if (oparg & 0x04), | ||
| closure if (oparg & 0x08), | ||
| codeobj -- func)) { |
There was a problem hiding this comment.
Too bad we can't write func: PyFunctionObject * yet -- I've gotta add that to the grammar, it would add the casts and save the ugly extra func_obj variable.
Comment on lines
3042
to
3037
| Py_DECREF(start); | ||
| Py_DECREF(stop); | ||
| Py_XDECREF(step); |
There was a problem hiding this comment.
Oh, we should augment DECREF_INPUTS() to use XDECREF for conditional inputs.
Comment on lines
+3584
to
+3591
| PyObject *annotations = (oparg & 0x04) ? PEEK(1 + ((oparg & 0x08) ? 1 : 0) + ((oparg & 0x04) ? 1 : 0)) : NULL; | ||
| PyObject *kwdefaults = (oparg & 0x02) ? PEEK(1 + ((oparg & 0x08) ? 1 : 0) + ((oparg & 0x04) ? 1 : 0) + ((oparg & 0x02) ? 1 : 0)) : NULL; | ||
| PyObject *defaults = (oparg & 0x01) ? PEEK(1 + ((oparg & 0x08) ? 1 : 0) + ((oparg & 0x04) ? 1 : 0) + ((oparg & 0x02) ? 1 : 0) + ((oparg & 0x01) ? 1 : 0)) : NULL; |
There was a problem hiding this comment.
Let's hope the compiler optimizes this. (Though it's not perf critical.)
iritkatriel
requested review from
rhettinger,
vsajip,
1st1,
asvetlov and
kumaraditya303
as code owners
iritkatriel
force-pushed
the
slice_etc
branch
from
77af074
to
98c053b
Compare
iritkatriel
removed request for
vsajip,
1st1,
asvetlov,
rhettinger and
kumaraditya303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.