gh-98831: rewrite RERAISE and CLEANUP_THROW in the instruction definition DSL #101511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Feb 1, 2023
•
iritkatriel
commented
- Issue: Generate the interpreter #98831
iritkatriel
added
skip news
interpreter-core
iritkatriel
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit df2e964 🤖 If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
🔨 test-with-buildbots
gvanrossum
approved these changes
Feb 2, 2023
| PyObject *tb = PyException_GetTraceback(val); | ||
| _PyErr_Restore(tstate, exc, val, tb); | ||
| assert(exc && PyExceptionInstance_Check(exc)); | ||
| Py_INCREF(exc); |
There was a problem hiding this comment.
Subtle: this is needed because it stays on the stack when we goto exception_unwind, so the latter will POP and DECREF it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.