-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-99276 - Updated Doc/faq/general.rst #101396
gh-99276 - Updated Doc/faq/general.rst #101396
Conversation
workingpayload
commented
Jan 28, 2023
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Add link to the first article about Python #99276
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, but:
- this is an article not a book, so doesn't belong in the books section
- this article is already mentioned in the previous section about articles: https://docs.python.org/3/faq/general.html#are-there-any-published-articles-about-python-that-i-can-reference
Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:
Please could you update the PR?
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Yeah Sure!! |
I have made the requested changes; please review again |
Thanks for making the requested changes! @hugovk: please review the changes made to this pull request. |
Rather than adding that extra line, shall we add an inline link? For example, to add the link around "very first article": -The very first article about Python was written in 1991 and is now quite
-outdated.
+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was
+written in 1991 and is now quite outdated. |
Yeah sure!! |
I have made the requested changes; please review again |
Thanks for making the requested changes! @hugovk: please review the changes made to this pull request. |
I have made the requested changes; please review again |
Thanks for making the requested changes! @hugovk: please review the changes made to this pull request. |
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @workingpayload for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-101461 is a backport of this pull request to the 3.11 branch. |
GH-101462 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit df0068c) Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit df0068c) Co-authored-by: Raj <51259329+workingpayload@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
* main: pythongh-101440: fix json snippet error in logging-cookbook.rst (python#101439) pythongh-99276 - Updated Doc/faq/general.rst (python#101396) Add JOBS parameter to docs Makefile (python#101395) pythongh-98831: rewrite GET_LEN, GET_ITER, BEFORE_WITH and a few simple opcodes in the instruction definition DSL (python#101443) pythongh-77607: Improve accuracy of os.path.join docs (python#101406) Fixes typo in asyncio.TaskGroup context manager code example (python#101449) pythongh-98831: Clean up and add cache size static_assert to macro (python#101442) pythongh-99955: use SUCCESS/ERROR return values in optimizer and assembler. Use RETURN_IF_ERROR where appropriate. Fix a couple of bugs. (python#101412)