Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101229: Add tests for aliases of imported names #101230

Merged
merged 1 commit into from
Jan 30, 2023
Merged

gh-101229: Add tests for aliases of imported names #101230

merged 1 commit into from
Jan 30, 2023

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jan 22, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 22, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 22, 2023
@Eclips4 Eclips4 changed the title gh-101229: Add tests for aliases gh-101229: Add tests for aliases of imported names Jan 22, 2023
@Eclips4
Copy link
Member Author

Eclips4 commented Jan 23, 2023

@sobolevn can you review this?

hauntsaninja
hauntsaninja approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

sobolevn
sobolevn approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja hauntsaninja merged commit 28db978 into python:main Jan 30, 2023
@miss-islington
Copy link
Contributor

Thanks @Eclips4 for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-101433 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2023
@Eclips4 @miss-islington
pythongh-101229: Add tests for aliases of imported names (pythonGH-10…
13a680d 
…1230)

(cherry picked from commit 28db978)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
@bedevere-bot
Copy link

GH-101434 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 30, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2023
@Eclips4 @miss-islington
pythongh-101229: Add tests for aliases of imported names (pythonGH-10…
48f2499 
…1230)

(cherry picked from commit 28db978)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 30, 2023
@miss-islington @Eclips4
gh-101229: Add tests for aliases of imported names (GH-101230)
3adac41 
(cherry picked from commit 28db978)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 30, 2023
@miss-islington @Eclips4
gh-101229: Add tests for aliases of imported names (GH-101230)
faf8068 
(cherry picked from commit 28db978)

Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
mdboom pushed a commit to mdboom/cpython that referenced this pull request Jan 31, 2023
@Eclips4 @mdboom
pythongh-101229: Add tests for aliases of imported names (python#101230)
315aed1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Eclips4 @miss-islington @bedevere-bot @sobolevn @hauntsaninja