Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop() #100412

Merged
merged 8 commits into from
Jan 10, 2023
Merged

[3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop() #100412

merged 8 commits into from
Jan 10, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 21, 2022 •
edited by bedevere-bot
Loading

They are deferred to Python 3.12.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.10 only security fixes label Dec 21, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 21, 2022
Closed
@gvanrossum gvanrossum changed the title gh-100160: Remove any deprecation warnings in asyncio.get_event_loop() gh-100160: [3.11] Remove any deprecation warnings in asyncio.get_event_loop() Dec 21, 2022
@gvanrossum gvanrossum changed the title gh-100160: [3.11] Remove any deprecation warnings in asyncio.get_event_loop() [3.11] gh-100160: Remove any deprecation warnings in asyncio.get_event_loop() Dec 21, 2022
gvanrossum
gvanrossum reviewed Dec 21, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obv. this is a draft PR so this review is also a draft. :-)

Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review December 22, 2022 07:37
@serhiy-storchaka
Copy link
Member Author

Thank you for your review Guido. I switched it to draft to be sure that it will not be accidentally merged.

The hard part in these PRs (#100410 and #100412) is documentation. It is difficult to find good place where all this mess should be documented, and I am bad in writing English. I think that non-documentation part is ready, but I am not sure about the documentation. Fill free to commit directly to this branch or create a new PR based on it.

@pepoluan pepoluan mentioned this pull request Dec 29, 2022
Merged
5 tasks
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 10, 2023
Closed
gvanrossum
gvanrossum reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here re a bunch of doc suggestions. I will merge those and then approve the PR.

Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-policy.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-policy.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-policy.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
gvanrossum
gvanrossum reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more tense changes.

Doc/library/asyncio-eventloop.rst Outdated Show resolved Hide resolved
Doc/library/asyncio-policy.rst Outdated Show resolved Hide resolved
@gvanrossum gvanrossum merged commit 1b2459d into python:3.11 Jan 10, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka and @gvanrossum, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1b2459dc64b1c3eea89312ea9bf422f8d7c75bb2 3.10

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 12, 2023
@serhiy-storchaka
[3.10] [3.11] pythongh-100160: Remove any deprecation warnings in asy…
040373f 
…ncio.get_event_loop() (pythonGH-100412)

Some deprecation warnings will reappear (in a slightly different form) in 3.12.

Co-authored-by: Guido van Rossum <guido@python.org>.
(cherry picked from commit 1b2459d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 12, 2023
Merged
@bedevere-bot
Copy link

GH-100970 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 12, 2023
serhiy-storchaka added a commit that referenced this pull request Jan 13, 2023
@serhiy-storchaka
[3.10] gh-100160: Remove any deprecation warnings in asyncio.get_even…
87f9b1d 
…t_loop() (GH-100412) (GH-100970)

Some deprecation warnings will reappear (in a slightly different form) in 3.12.

Co-authored-by: Guido van Rossum <guido@python.org>.
(cherry picked from commit 1b2459d)
@serhiy-storchaka serhiy-storchaka deleted the asyncio-get_event_loop3-3.11 branch January 13, 2023 07:35
@hroncok hroncok mentioned this pull request Jan 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ambv ambv Awaiting requested review from ambv

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@gvanrossum gvanrossum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @gvanrossum