Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100176: Tools/iobench: Remove redundant compat code for Python <= 3.2 #100197

Merged
merged 7 commits into from
Apr 8, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 12, 2022

Python 3.2 has been EOL since 2016-02-20 and 2.7 since 2020-01-01, so we can remove these old compatibility checks.

https://devguide.python.org/versions/

Also use f-strings and adjust some whitespace.


Ping also @pitrou who created this file with this note in 2010 in a69ba65:

This file should be kept compatible with both Python 2.6 and Python >= 3.0.


@netlify
Copy link

netlify bot commented Dec 12, 2022

Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 59f2f14
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63972a48fa3a93000bfd01fb
😎 Deploy Preview https://deploy-preview-100197--python-cpython-preview.netlify.app/library/profile
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hugovk hugovk force-pushed the 100176-tools-iobench branch from b080903 to 59f2f14 Compare December 12, 2022 13:19
@hugovk
Copy link
Member Author

hugovk commented Jan 30, 2023

See https://discuss.python.org/t/do-we-still-need-tools-io-cc-string-bench/22557 for a discussion about Tools/{io,cc,string}bench, whether to leave, modernise, move or delete them.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@hugovk
Copy link
Member Author

hugovk commented Feb 12, 2023

@hugovk
Copy link
Member Author

hugovk commented Apr 8, 2023

Let's hold off a bit merging this, we can remove the file instead:

No decision there in a couple of months, let's merge this. We can still remove the file later.

@hugovk hugovk merged commit b22d021 into python:main Apr 8, 2023
@hugovk hugovk deleted the 100176-tools-iobench branch April 8, 2023 09:05
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
…on <= 3.2 (python#100197)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants