-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-100176: Tools/iobench: Remove redundant compat code for Python <= 3.2 #100197
Conversation
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
b080903
to
59f2f14
Compare
See https://discuss.python.org/t/do-we-still-need-tools-io-cc-string-bench/22557 for a discussion about |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Let's hold off a bit merging this, we can remove the file instead: |
No decision there in a couple of months, let's merge this. We can still remove the file later. |
…on <= 3.2 (python#100197) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Python 3.2 has been EOL since 2016-02-20 and 2.7 since 2020-01-01, so we can remove these old compatibility checks.
https://devguide.python.org/versions/
Also use f-strings and adjust some whitespace.
Ping also @pitrou who created this file with this note in 2010 in a69ba65: