Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite3.Cursor.fetchone may return an object returned by row_factory #97661

Closed
jiajunjie opened this issue Sep 30, 2022 · 3 comments · Fixed by #97662
Closed

sqlite3.Cursor.fetchone may return an object returned by row_factory #97661

jiajunjie opened this issue Sep 30, 2022 · 3 comments · Fixed by #97662
Labels
docs Documentation in the Doc dir

Comments

@jiajunjie
Copy link
Contributor

jiajunjie commented Sep 30, 2022 •
edited
Loading

Documentation

cpython/Doc/library/sqlite3.rst

Lines 1426 to 1429 in 9a11ed8

.. method:: fetchone()
Return the next row of a query result set as a :class:`tuple`.
Return ``None`` if no more data is available.

@jiajunjie jiajunjie added the docs Documentation in the Doc dir label Sep 30, 2022
@bedevere-bot bedevere-bot mentioned this issue Sep 30, 2022
Merged
@erlend-aasland
Copy link
Contributor

We should also change the docs for fetchmany and fetchall.

@erlend-aasland erlend-aasland linked a pull request Oct 5, 2022 that will close this issue
gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs #97662
Merged
erlend-aasland pushed a commit that referenced this issue Oct 5, 2022
@jiajunjie @CAM-Gerlach
gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (#97662)
4b83cd0 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 5, 2022
@jiajunjie @miss-islington
pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (pyt…
1913fb0 
…honGH-97662)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Oct 5, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 5, 2022
@jiajunjie @miss-islington
pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (pyt…
70b62b2 
…honGH-97662)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Oct 5, 2022
Merged
@erlend-aasland
Copy link
Contributor

Fixed by:

@erlend-aasland
Copy link
Contributor

Thanks for the report and PR, Jia!

miss-islington added a commit that referenced this issue Oct 5, 2022
@miss-islington @jiajunjie
gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (GH-97662)
3c09deb 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
miss-islington added a commit that referenced this issue Oct 5, 2022
@miss-islington @jiajunjie
gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (GH-97662)
79b5c1a 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this issue Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
4bb5d9d 
* main: (66 commits)
  pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)
  docs(typing): add "see PEP 675" to LiteralString (python#97926)
  pythongh-97850: Remove all known instances of module_repr() (python#97876)
  I changed my surname early this year (python#96671)
  pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)
  pythongh-91539: improve performance of get_proxies_environment  (python#91566)
  build(deps): bump actions/stale from 5 to 6 (python#97701)
  pythonGH-95172 Make the same version `versionadded` oneline (python#95172)
  pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)
  pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)
  pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)
  pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383)
  pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759)
  pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251)
  pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662)
  pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644)
  pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756)
  pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778)
  pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826)
  Add re.VERBOSE flag documentation example (python#97678)
  ...
mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022
@jiajunjie @CAM-Gerlach @mpage
pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (pyt…
45b9d05 
…hon#97662)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
pablogsal pushed a commit that referenced this issue Oct 22, 2022
@miss-islington @jiajunjie @pablogsal
gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (GH-97662)
5f43097 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
sqlite3 issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs jiajunjie/cpython
2 participants
@erlend-aasland @jiajunjie