test_cppext does not import/run the C++ extension #94751
Labels
tests
Tests in the Lib/test dir
Comments
encukou
added a commit
that referenced
this issue
Jul 12, 2022
) This is a quick-and-dirty way to run the C++ tests. It can definitely be improved in the future, but it should fail when things go wrong. - Run test functions on import (yes, this can definitely be improved) - Fudge setuptools metadata (name & version) to make the extension installable - Install and import the extension in test_cppext
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 12, 2022
…ythonGH-94754) This is a quick-and-dirty way to run the C++ tests. It can definitely be improved in the future, but it should fail when things go wrong. - Run test functions on import (yes, this can definitely be improved) - Fudge setuptools metadata (name & version) to make the extension installable - Install and import the extension in test_cppext (cherry picked from commit ec5db53) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
Merged the MVP, but there's still work to do:
|
encukou
added a commit
that referenced
this issue
Jul 13, 2022
) (#94780) This is a quick-and-dirty way to run the C++ tests. It can definitely be improved in the future, but it should fail when things go wrong. - Run test functions on import (yes, this can definitely be improved) - Fudge setuptools metadata (name & version) to make the extension installable - Install and import the extension in test_cppext (cherry picked from commit ec5db53) Co-authored-by: Petr Viktorin <encukou@gmail.com>
Right, for now it's its only purpose as written at top of Lib/test/_testcppext.cpp: And Lib/test/test_cppext.py: The reason is that I was too lazy to finish the work to actually import the built extension. I got enough C++ issues to handle. By the way, it seems like most of the work to fix C++ warnings has been reverted by commit 6cbb57f. I also got busy with replacing distutils with setuptools (using venv). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
test_cppexttest case only checks that the C++ extension builds. It does not import and run test cases, so it can't catch runtime issues like #94731.The text was updated successfully, but these errors were encountered: