Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makesetup can fail on macOS and uses wrong CFLAGS #94404

Closed
tiran opened this issue Jun 29, 2022 · 0 comments
Closed

makesetup can fail on macOS and uses wrong CFLAGS #94404

tiran opened this issue Jun 29, 2022 · 0 comments
Labels
3.11 only security fixes 3.12 bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Jun 29, 2022 •
edited
Loading

Bug report

The script Modules/makesetup has two issues

  1. It uses sed i command with multiple escapes newlines. The feature works fine in GNU sed but does not work correctly with macOS' BSD sed. @ned-deily found a workaround for the problem. The r command with an external replacement file works correctly on GNU and BSD sed.

  2. makesetup creates wrong compile rules for object files that end up in a shared library. The variables $(CCSHARED) $(PY_CFLAGS_NODIST) $(PY_CPPFLAGS) are missing some flags like address sanitizer. The script should create rules with $(PY_STDMODULE_CFLAGS) $(CCSHARED) instead.

  3. the order of cflags can break builds. For example macOS ARM64 builds are broken because -I./Modules/_decimal/libmpdec comes after -I/opt/homebrew/include and the buildbot seems to come with an incompatible libmpdec header. Module-specific CFLAGs should come before Python CFLAGs. It is probably easier to move module CFLAGS before PY_STDMODULE_CFLAGS. The homebrew flag comes from PY_CPPFLAGS and CONFIGURE_CPPFLAGS.
@tiran tiran added type-bug An unexpected behavior, bug, or error build The build process and cross-build 3.11 only security fixes 3.12 bugs and security fixes labels Jun 29, 2022
tiran added a commit to tiran/cpython that referenced this issue Jun 29, 2022
@tiran
pythongh-94404: makesetup: use correct CFLAGS and macOS workaround
10acb92 
``makesetup`` now works around an issue with sed on macOS and uses correct
CFLAGS for object files that end up in a shared extension.
@bedevere-bot bedevere-bot mentioned this issue Jun 29, 2022
Merged
tiran added a commit that referenced this issue Jun 29, 2022
@tiran
gh-94404: makesetup: use correct CFLAGS and macOS workaround (GH-94405)
5150cbc 
``makesetup`` now works around an issue with sed on macOS and uses correct
CFLAGS for object files that end up in a shared extension.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 29, 2022
@tiran @miss-islington
pythongh-94404: makesetup: use correct CFLAGS and macOS workaround (p…
d54afdf 
…ythonGH-94405)

``makesetup`` now works around an issue with sed on macOS and uses correct
CFLAGS for object files that end up in a shared extension.
(cherry picked from commit 5150cbc)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this issue Jun 29, 2022
Merged
miss-islington added a commit that referenced this issue Jun 29, 2022
@miss-islington @tiran
gh-94404: makesetup: use correct CFLAGS and macOS workaround (GH-94405)
aaa85b5 
``makesetup`` now works around an issue with sed on macOS and uses correct
CFLAGS for object files that end up in a shared extension.
(cherry picked from commit 5150cbc)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit to tiran/cpython that referenced this issue Jun 29, 2022
@tiran
pythongh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS
78cb92f 
``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
@bedevere-bot bedevere-bot mentioned this issue Jun 29, 2022
Merged
tiran added a commit that referenced this issue Jun 29, 2022
@tiran
gh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS (GH-94413)
6485c3c 
``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
tiran added a commit to tiran/cpython that referenced this issue Jun 29, 2022
@tiran
[3.11] pythongh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS (p…
22491a6 
…ythonGH-94413)

``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
(cherry picked from commit 6485c3c)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this issue Jun 29, 2022
Merged
tiran added a commit that referenced this issue Jun 29, 2022
@tiran
[3.11] gh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS (GH-94413…
a548a45 
…) (GH-94415)

``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
Co-authored-by: Christian Heimes <christian@python.org>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Jun 30, 2022
@tiran @gvanrossum
pythongh-94404: makesetup: use correct CFLAGS and macOS workaround (p…
bf43498 
…ythonGH-94405)

``makesetup`` now works around an issue with sed on macOS and uses correct
CFLAGS for object files that end up in a shared extension.
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Jun 30, 2022
@tiran @gvanrossum
pythongh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS (pythonG…
6e77150 
…H-94413)

``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
@tiran tiran closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tiran