Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded module state from _json module #94393

Closed
erlend-aasland opened this issue Jun 28, 2022 · 0 comments · Fixed by #94394
Closed

Remove unneeded module state from _json module #94393

erlend-aasland opened this issue Jun 28, 2022 · 0 comments · Fixed by #94394
Labels
3.12 bugs and security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

The _json module got multi-phase initialisation and heap types in GH-17835. However, there is no need for it to have module state. We can remove approx. 50 lines of code, and get rid of the unneeded state allocation.
@erlend-aasland erlend-aasland added type-feature A feature request or enhancement extension-modules C modules in the Modules dir labels Jun 28, 2022
@bedevere-bot bedevere-bot mentioned this issue Jun 28, 2022
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Jun 28, 2022
@erlend-aasland
pythongh-94393: Remove unneeded module state from _json
1ec6f7a
@erlend-aasland erlend-aasland linked a pull request Jun 28, 2022 that will close this issue
gh-94393: Remove unneeded module state from _json #94394
Merged
@erlend-aasland erlend-aasland added the 3.12 bugs and security fixes label Jun 28, 2022
@erlend-aasland erlend-aasland mentioned this issue Jun 29, 2022
Closed
2 tasks
erlend-aasland pushed a commit that referenced this issue Jul 2, 2022
gh-94393: Remove unneeded module state from _json (#94394)
3a2e615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement
Projects
JSON issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-94393: Remove unneeded module state from _json erlend-aasland/cpython
1 participant
@erlend-aasland