Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pyvenv.cfg-relocation part of the interpreter initialization instead of the site module #126985

Closed
FFY00 opened this issue Nov 18, 2024 · 1 comment
Closed

Make pyvenv.cfg-relocation part of the interpreter initialization instead of the site module #126985

FFY00 opened this issue Nov 18, 2024 · 1 comment
Labels
type-feature A feature request or enhancement

Comments

@FFY00
Copy link
Member

FFY00 commented Nov 18, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

Currently, the mechanism behind virtual environments is implemented in the site module. This means that disabling the site initialization (passing -S) disables virtual environments.

I would like to move the virtual environment detection from site to the interpreter initialization (getpath), which would essentially consist of setting sys.prefix to sys.exec_prefix to the virtual environment prefix in getpath.

The motivation is the same as GH-126793, the same UX example applies. Running python -S -m ensurepip inside a virtual environment would install to the system, instead of the virtual environment.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@FFY00 FFY00 added the type-feature A feature request or enhancement label Nov 18, 2024
FFY00 added a commit to FFY00/cpython that referenced this issue Nov 18, 2024
@FFY00
pythonGH-126985: move pyconf.cfg detection from site to getpath
1380972 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@bedevere-app bedevere-app bot mentioned this issue Nov 18, 2024
Merged
FFY00 added a commit to FFY00/cpython that referenced this issue Nov 22, 2024
@FFY00
Merge branch 'main' into pythongh-126985
caf5984
FFY00 added a commit that referenced this issue Nov 26, 2024
@FFY00
GH-126985: move pyvenv.cfg detection from site to getpath (#126987)
2b0e2b2
@FFY00 FFY00 closed this as completed Nov 26, 2024
@FFY00 FFY00 mentioned this issue Nov 26, 2024
Closed
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
FFY00 added a commit to FFY00/cpython that referenced this issue Dec 15, 2024
@FFY00
pythonGH-126985: Don't override venv dectection whith PYTHONHOME
aca9769 
PYTHONHOME should only override the base prefix calculation, it should
have no effect on detecting if we are running inside a virtual
environment.

Signed-off-by: Filipe Laíns <lains@riseup.net
@bedevere-app bedevere-app bot mentioned this issue Dec 15, 2024
Merged
FFY00 added a commit that referenced this issue Dec 15, 2024
@FFY00
GH-126985: Don't override venv detection with PYTHONHOME (#127968)
b74c8f5
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@FFY00 @srinivasreddy
pythonGH-126985: Don't override venv detection with PYTHONHOME (pytho…
a88f0c3 
…n#127968)
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@FFY00 @ebonnal
pythonGH-126985: move pyvenv.cfg detection from site to getpath (pyth…
7ea1387 
…on#126987)
@befeleme
Copy link
Contributor

Cross-referencing for visibility: #128779 - this has started to happen since Python 3.14.0a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FFY00 @befeleme