Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.path.exists and lexists no longer allow a keyword argument on Windows #124917

Closed
JelleZijlstra opened this issue Oct 3, 2024 · 1 comment
Closed

os.path.exists and lexists no longer allow a keyword argument on Windows #124917

JelleZijlstra opened this issue Oct 3, 2024 · 1 comment
Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Oct 3, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Historically os.path.exists and os.path.lexists have accepted their argument as a keyword, path=. However, in 3.13 on Windows (#118755) these functions were reimplemented in C and the C functions only accept a positional argument. This was detected by typeshed CI (python/typeshed#12730).

Probably doesn't have a lot of practical effect (why would you use keyword arguments for these functions?), but it's better to keep this consistent. I'll send a PR.

CPython versions tested on:

3.13

Operating systems tested on:

No response

Linked PRs
@JelleZijlstra JelleZijlstra added the type-bug An unexpected behavior, bug, or error label Oct 3, 2024
@bedevere-app bedevere-app bot mentioned this issue Oct 3, 2024
Merged
@picnixz picnixz added the extension-modules C modules in the Modules dir label Oct 3, 2024
JelleZijlstra added a commit that referenced this issue Oct 11, 2024
@JelleZijlstra
gh-124917: Allow keyword args to os.path.exists/lexists on Windows (#…
cc2938a 
…124918)
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue Oct 11, 2024
@JelleZijlstra
[3.13] pythongh-124917: Allow keyword args to os.path.exists/lexists …
76f4a76 
…on Windows (pythonGH-124918)

(cherry picked from commit cc2938a)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Oct 11, 2024
Merged
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue Oct 11, 2024
@JelleZijlstra
[3.12] pythongh-124917: Allow keyword args to os.path.exists/lexists …
cf884bd 
…on Windows (pythonGH-124918)

(cherry picked from commit cc2938a)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Oct 11, 2024
Merged
JelleZijlstra added a commit that referenced this issue Oct 11, 2024
@JelleZijlstra
[3.13] gh-124917: Allow keyword args to os.path.exists/lexists on Win…
e646cc3 
…dows (GH-124918) (#125332)

(cherry picked from commit cc2938a)
JelleZijlstra added a commit that referenced this issue Oct 11, 2024
@JelleZijlstra
[3.12] gh-124917: Allow keyword args to os.path.exists/lexists on Win…
4ab19f9 
…dows (GH-124918) (#125334)

(cherry picked from commit cc2938a)
@nineteendo
Copy link
Contributor

Can you close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JelleZijlstra @picnixz @nineteendo