Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

framelocalsproxy_new() crash if called with no arguments #124513

Closed
vstinner opened this issue Sep 25, 2024 · 2 comments
Closed

framelocalsproxy_new() crash if called with no arguments #124513

vstinner opened this issue Sep 25, 2024 · 2 comments
Labels
type-bug An unexpected behavior, bug, or error type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@vstinner
Copy link
Member

vstinner commented Sep 25, 2024 •
edited by bedevere-app bot
Loading

Bug report

Example on Python 3.13.0rc2:

$ python3.13
>>> import sys
>>> FrameLocalsProxy=type([sys._getframe().f_locals for x in range(1)][0])
... 
>>> FrameLocalsProxy()
Erreur de segmentation (core dumped)

The bug was discovered by zope.interface test suite: zopefoundation/zope.interface#323 (comment)

I'm working on a fix.

Linked PRs
@vstinner vstinner added type-bug An unexpected behavior, bug, or error type-crash A hard crash of the interpreter, possibly with a core dump labels Sep 25, 2024
vstinner added a commit to vstinner/cpython that referenced this issue Sep 25, 2024
@vstinner
pythongh-124513: Check args in framelocalsproxy_new()
fcf7a59
@MandeepSinghPB08 MandeepSinghPB08 mentioned this issue Sep 25, 2024
Closed
vstinner added a commit to vstinner/cpython that referenced this issue Sep 25, 2024
@vstinner
pythongh-124513: Check args in framelocalsproxy_new()
cdae0a4 
Fix a crash in FrameLocalsProxy constructor: check the number of
arguments.
@bedevere-app bedevere-app bot mentioned this issue Sep 25, 2024
Merged
@vstinner vstinner mentioned this issue Sep 25, 2024
Closed
vstinner added a commit that referenced this issue Sep 25, 2024
@vstinner
gh-124513: Check args in framelocalsproxy_new() (#124515)
d6954b6 
Fix a crash in FrameLocalsProxy constructor: check the number of
arguments.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 25, 2024
@vstinner @miss-islington
pythongh-124513: Check args in framelocalsproxy_new() (pythonGH-124515)
08f74df 
Fix a crash in FrameLocalsProxy constructor: check the number of
arguments.
(cherry picked from commit d6954b6)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot mentioned this issue Sep 25, 2024
Merged
emilyemorehouse added a commit to lysnikolaou/cpython that referenced this issue Sep 26, 2024
@emilyemorehouse
Merge branch 'main' into fix-help-double-prompt
4cdb3ae 
* main: (69 commits)
  Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566)
  pythongh-124412: Add helpers for converting annotations to source format (python#124551)
  pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561)
  For-else deserves its own section in the tutorial (python#123946)
  Add 3.13 as a version option to the crash issue template (python#124560)
  pythongh-123242: Note that type.__annotations__ may not exist (python#124557)
  pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479)
  pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227)
  pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752)
  pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856)
  pythongh-124370: Add "howto" for free-threaded Python (python#124371)
  pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278)
  pythongh-119400:  make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400  (pythonGH-119401)
  pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337)
  pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449)
  pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490)
  pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
  pythongh-124513: Check args in framelocalsproxy_new() (python#124515)
  pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480)
  Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489)
  ...
Yhg1s pushed a commit that referenced this issue Sep 30, 2024
@miss-islington @vstinner
[3.13] gh-124513: Check args in framelocalsproxy_new() (GH-124515) (#…
62f691f 
…124539)

gh-124513: Check args in framelocalsproxy_new() (GH-124515)

Fix a crash in FrameLocalsProxy constructor: check the number of
arguments.
(cherry picked from commit d6954b6)

Co-authored-by: Victor Stinner <vstinner@python.org>
@ZeroIntensity
Copy link
Member

Everything is done here, right?

@vstinner
Copy link
Member Author

vstinner commented Oct 3, 2024

Everything is done here, right?

Correct, I close the issue.

@vstinner vstinner closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @ZeroIntensity