Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test tegression from gh-117711: Assuming wheels are deleted from source when WHEEL_PKG_DIR is set #120418

Closed
stefanor opened this issue Jun 12, 2024 · 0 comments
Closed

Test tegression from gh-117711: Assuming wheels are deleted from source when WHEEL_PKG_DIR is set #120418

stefanor opened this issue Jun 12, 2024 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@stefanor
Copy link
Contributor

stefanor commented Jun 12, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

test_makefile_test_folders (test.test_tools.test_makefile.TestMakefile.test_makefile_test_folders) ... FAIL

======================================================================
FAIL: test_makefile_test_folders (test.test_tools.test_makefile.TestMakefile.test_makefile_test_folders)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.12/test/test_tools/test_makefile.py", line 75, in test_makefile_test_folders
    self.assertSetEqual(unique_test_dirs, set(used))
AssertionError: Items in the second set but not the first: 'test/wheeldata'

----------------------------------------------------------------------
Ran 1 test in 0.009s

This is a regression caused by the change in #117712, which assumed that whenever WHEEL_PKG_DIR is set, the .whl files in the testdata will be deleted.

CPython versions tested on:

3.12

Operating systems tested on:

Linux

Linked PRs
@stefanor stefanor added the type-bug An unexpected behavior, bug, or error label Jun 12, 2024
@bedevere-app bedevere-app bot mentioned this issue Jun 12, 2024
Merged
@stefanor stefanor mentioned this issue Jun 12, 2024
Merged
stefanor added a commit to stefanor/cpython that referenced this issue Jun 12, 2024
@stefanor
pythongh-120418: Don't assume wheeldata is deleted if WHEEL_PKG_DIR…
b38ac70 
… is set

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
stefanor added a commit to stefanor/cpython that referenced this issue Jun 12, 2024
@stefanor
pythongh-120418: Don't assume wheeldata is deleted if WHEEL_PKG_DIR…
f9826d9 
… is set

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
vstinner pushed a commit that referenced this issue Jun 12, 2024
@stefanor
gh-120418: Don't assume wheeldata is deleted if WHEEL_PKG_DIR is set (
030b452 
#120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 12, 2024
@stefanor @miss-islington
pythongh-120418: Don't assume wheeldata is deleted if WHEEL_PKG_DIR…
b68f388 
… is set (pythonGH-120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
(cherry picked from commit 030b452)

Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
@bedevere-app bedevere-app bot mentioned this issue Jun 12, 2024
Merged
vstinner pushed a commit that referenced this issue Jun 12, 2024
@miss-islington @stefanor
[3.13] gh-120418: Don't assume wheeldata is deleted if `WHEEL_PKG_DIR…
f723728 
…` is set (GH-120419) (#120432)

gh-120418: Don't assume wheeldata is deleted if `WHEEL_PKG_DIR` is set (GH-120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
(cherry picked from commit 030b452)

Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@stefanor @mrahtz
pythongh-120418: Don't assume wheeldata is deleted if WHEEL_PKG_DIR…
d596174 
… is set (python#120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@stefanor @noahbkim
pythongh-120418: Don't assume wheeldata is deleted if WHEEL_PKG_DIR…
e4c611e 
… is set (python#120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@stefanor @estyxx
pythongh-120418: Don't assume wheeldata is deleted if WHEEL_PKG_DIR…
2434134 
… is set (python#120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanor @sobolevn