Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new REPL in python -m asyncio #118894

Closed
sobolevn opened this issue May 10, 2024 · 0 comments
Closed

Add support for new REPL in python -m asyncio #118894

sobolevn opened this issue May 10, 2024 · 0 comments
Assignees
Labels
topic-asyncio topic-repl Related to the interactive shell type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented May 10, 2024

Feature or enhancement

They are different now:
изображение

Hm, right now I don't see any simple way of merging these two together:

class AsyncIOInteractiveConsole(code.InteractiveConsole):
def __init__(self, locals, loop):
super().__init__(locals)
self.compile.compiler.flags |= ast.PyCF_ALLOW_TOP_LEVEL_AWAIT
self.loop = loop

and

def run_multiline_interactive_console(
mainmodule: ModuleType | None= None, future_flags: int = 0
) -> None:

I think that this would require some API change. Not sure which one, though :(

Refs #111201

Linked PRs

@sobolevn sobolevn added type-feature A feature request or enhancement topic-asyncio topic-repl Related to the interactive shell labels May 10, 2024
@github-project-automation github-project-automation bot moved this to Todo in asyncio May 10, 2024
@ambv ambv self-assigned this May 22, 2024
ambv added a commit to ambv/cpython that referenced this issue May 22, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 31, 2024
(cherry picked from commit 2237946)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this issue May 31, 2024
(cherry picked from commit 2237946)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@github-project-automation github-project-automation bot moved this from Todo to Done in asyncio Jun 2, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-asyncio topic-repl Related to the interactive shell type-feature A feature request or enhancement
Projects
Status: Done
Development

No branches or pull requests

3 participants